Allow running coretests/alloctests without corebenches/allocbenches#2183
Merged
bors-ferrocene[bot] merged 3 commits intomainfrom Mar 24, 2026
Merged
Allow running coretests/alloctests without corebenches/allocbenches#2183bors-ferrocene[bot] merged 3 commits intomainfrom
coretests/alloctests without corebenches/allocbenches#2183bors-ferrocene[bot] merged 3 commits intomainfrom
Conversation
Urhengulas
force-pushed
the
jh/no-doc-is-not-yes-bench
branch
4 times, most recently
from
63b3615 to
4eb2420
Compare
Urhengulas
force-pushed
the
jh/no-doc-is-not-yes-bench
branch
from
4eb2420 to
8ac09bc
Compare
Urhengulas
added
waiting-on-review
and removed
blocked
jyn514
requested changes
Mar 19, 2026
Contributor
jyn514
left a comment
jyn514
left a comment
There was a problem hiding this comment.
This looks good! Just one comment.
| # HACK: work around incorrect caching for profiler_builtins. | ||
| rm -rf build/host/stage1-std | ||
| ./x test --stage 1 --coverage=library --no-doc library/core library/alloc -- --list | ||
| ./x test --stage 1 --coverage=library --tests library/core library/alloc -- --list |
Contributor
There was a problem hiding this comment.
I think we also need to update .circleci/workflow.yml, right?
Member
Author
There was a problem hiding this comment.
There are no --no-docs in that file anymore, they have been changed in the Upstream Pull PR already
jyn514
added
waiting-on-author
Urhengulas
added
waiting-on-review
and removed
waiting-on-author
Urhengulas
force-pushed
the
jh/no-doc-is-not-yes-bench
branch
from
8ac09bc to
89ea530
Compare
Urhengulas
force-pushed
the
jh/no-doc-is-not-yes-bench
branch
from
89ea530 to
e96874f
Compare
Contributor
github-actions
Bot
added
backport:maybe
ferrocene-automations Bot
pushed a commit
that referenced
this pull request
Mar 25, 2026
Ferrocene-backport-of: #2183
bors-ferrocene Bot
added a commit
that referenced
this pull request
Mar 25, 2026
2240: Backport to `release/1.95` r=tshepang a=ferrocene-automations[bot] This PR backports the following PRs to the `release/1.95` branch: * #2183 Note that the automation failed to backport some PRs automatically. Check out the [backport:manual](https://github.com/ferrocene/ferrocene/pulls?q=is%3Apr+label%3Abackport%3Amanual) for a list of them. Co-authored-by: Urhengulas <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After this PR
corebenchesandallocbencheswill not be run for gathering code coverage anymore. Firstly this is the correct thing to do from a certification perspective, since benches should not be used for coverage. Secondly this speeds up compile and execution times noticeably.Most of the work happened upstream: rust-lang/rust#153143.
Test coverage diff
Executing
./x test library/core library/alloc --coverage=library --no-docon both this branch andmain(46b1135) shows that this PR changes coverage (with "count annotated lines as tested") like following: