Conversation
Contributor
Author
|
merged upstream, just waiting on the next upstream pull. |
jyn514
force-pushed
the
jyn/force-doctest-merge
branch
from
61b34a5 to
c483072
Compare
jyn514
added
waiting-on-author
bors-ferrocene Bot
added a commit
that referenced
this pull request
Apr 3, 2026
2265: blanket: Report all unused annotations at once r=Hoverbear a=jyn514 Cherry-picked from #2180. 2266: Fix `-C metadata` documentation r=Hoverbear a=jyn514 Fixes #8. Our docs: https://public-docs.ferrocene.dev/main/user-manual/rustc/cli.html#um_rustc_C_metadata Upstream's docs: https://doc.rust-lang.org/rustc/codegen-options/index.html#metadata 2267: Blanket: terminal output distinguishes annotated functions r=Hoverbear a=jyn514 Before, this was possible to distinguish in the generated HTML doc, but hard to figure out from CI logs. I verified locally that running `x test --coverage=library` shows the same output for fully/partially/untested in the terminal as shown in the HTML. Co-authored-by: Jynn Nelson <[email protected]>
bors-ferrocene Bot
added a commit
that referenced
this pull request
Apr 3, 2026
2265: blanket: Report all unused annotations at once r=Hoverbear a=jyn514 Cherry-picked from #2180. 2266: Fix `-C metadata` documentation r=Hoverbear a=jyn514 Fixes #8. Our docs: https://public-docs.ferrocene.dev/main/user-manual/rustc/cli.html#um_rustc_C_metadata Upstream's docs: https://doc.rust-lang.org/rustc/codegen-options/index.html#metadata Co-authored-by: Jynn Nelson <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
most of this is upstream work, see rust-lang/rust#153072. only e4561ae and d8f0ea3 are specific to ferrocene.
before: 54.9 seconds to merge coverage (total time: 2:28 with a hot cache)
after: TODO to merge coverage (total time: 5:03 with a hot cache)
In both cases the time to run blanket after merging profdata is trivial.