Extend libcore coverage for core::fmt, Part 2#2149
Merged
bors-ferrocene[bot] merged 8 commits intomainfrom Feb 14, 2026
Merged
Conversation
…s::iterator::Iterator>::count`
…er::traits::iterator::Iterator>::size_hint`
…er::traits::iterator::Iterator>::try_fold`
…tor::Iterator>::next`
Hoverbear
reviewed
Feb 11, 2026
Urhengulas
force-pushed
the
jh/libcore-coverage
branch
from
fc9b08e to
0b04096
Compare
bors-ferrocene Bot
added a commit
that referenced
this pull request
Feb 13, 2026
2149: Extend libcore coverage for `core::fmt`, Part 2 r=Hoverbear a=Urhengulas Cover functions of `library/core` that were added while adding `core::fmt` to the subset. See the commit messages for what tests for what functions have been added. # Test coverage diff Executing `./x test library/core library/alloc --coverage=library --no-doc` on both this branch and `main` (b683ce3) shows that this PR changes coverage (with "count annotated lines as tested") like following: | | main | this PR | Diff | | ---------------- | -------------------------- | -------------------------- | ----- | | Lines | 97.61% (25691/26321 lines) | 97.92% (25773/26321 lines) | +0.31% | | Fully Tested | 5909 | 5918 | +9 | | Partially tested | 22 | 13 | -9 | | Fully untested | 113 | 113 | +0 | | Fully ignored | 316 | 316 | +0 | | Total | 6357 | 6357 | +0 | 2152: Replace `print-target-features` with a run-make test r=tshepang a=jyn514 This test is highly specific to both the target and the exact version of LLVM installed. Rewrite it to only check that the feature boilerplate is printed, not the specific features shown. As a bonus, the test is now target-independent and easy to run locally. Co-authored-by: Urhengulas <[email protected]> Co-authored-by: Jynn Nelson <[email protected]> Co-authored-by: jyn <[email protected]>
Contributor
|
Build failed (retrying...):
|
bors-ferrocene Bot
added a commit
that referenced
this pull request
Feb 14, 2026
2149: Extend libcore coverage for `core::fmt`, Part 2 r=Hoverbear a=Urhengulas Cover functions of `library/core` that were added while adding `core::fmt` to the subset. See the commit messages for what tests for what functions have been added. # Test coverage diff Executing `./x test library/core library/alloc --coverage=library --no-doc` on both this branch and `main` (b683ce3) shows that this PR changes coverage (with "count annotated lines as tested") like following: | | main | this PR | Diff | | ---------------- | -------------------------- | -------------------------- | ----- | | Lines | 97.61% (25691/26321 lines) | 97.92% (25773/26321 lines) | +0.31% | | Fully Tested | 5909 | 5918 | +9 | | Partially tested | 22 | 13 | -9 | | Fully untested | 113 | 113 | +0 | | Fully ignored | 316 | 316 | +0 | | Total | 6357 | 6357 | +0 | 2155: Add s390x and ppc64le as supported targets r=tshepang a=Hoverbear Add s390x and ppc64le as supported targets. Co-authored-by: Urhengulas <[email protected]> Co-authored-by: Ana Hobden <[email protected]>
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded:
|
github-actions
Bot
added
backport:maybe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cover functions of
library/corethat were added while addingcore::fmtto the subset. See the commit messages for what tests for what functions have been added.Test coverage diff
Executing
./x test library/core library/alloc --coverage=library --no-docon both this branch andmain(b683ce3) shows that this PR changes coverage (with "count annotated lines as tested") like following: