blanket: Report all unused annotations at once

jyn514 · jyn514 · commit d8f0ea3ef6a8 · 2026-02-24T22:21:06.000-05:00
diff --git a/ferrocene/tools/blanket/src/rustc_driver.rs b/ferrocene/tools/blanket/src/rustc_driver.rs
@@ -38,13 +38,19 @@ pub fn coverage(cmd: &ShowCommand, report: &CoverageReport) -> Result<Vec<Functi
         )?);
     }
 
+    let mut saw_unused = false;
     for (filename, annotations) in annotations {
         for Annotation { start, end: _, unused } in annotations {
             if unused {
-                bail!("Unused annotation in {filename}:{start}");
+                eprintln!("Unused annotation in {filename}:{start}");
             }
+            saw_unused |= unused;
         }
     }
 
+    if saw_unused {
+        bail!("saw 1 or more unused annotations");
+    }
+
     Ok(coverage)
 }

Original file line number	Diff line number	Diff line change
`@@ -38,13 +38,19 @@ pub fn coverage(cmd: &ShowCommand, report: &CoverageReport) -> Result<Vec<Functi`
`38`	`38`	`)?);`
`39`	`39`	`}`
`40`	`40`
	`41`	`+ let mut saw_unused = false;`
`41`	`42`	`for (filename, annotations) in annotations {`
`42`	`43`	`for Annotation { start, end: _, unused } in annotations {`
`43`	`44`	`if unused {`
`44`		`- bail!("Unused annotation in {filename}:{start}");`
	`45`	`+ eprintln!("Unused annotation in {filename}:{start}");`
`45`	`46`	`}`
	`47`	`+ saw_unused \|= unused;`
`46`	`48`	`}`
`47`	`49`	`}`
`48`	`50`
	`51`	`+ if saw_unused {`
	`52`	`+ bail!("saw 1 or more unused annotations");`
	`53`	`+ }`
	`54`	`+`
`49`	`55`	`Ok(coverage)`
`50`	`56`	`}`