Skip to content

Maintenance updates#64

Merged
bors-ferrocene[bot] merged 7 commits intomainfrom
amanjeev/maintenance-updates
Nov 14, 2024
Merged

Maintenance updates#64
bors-ferrocene[bot] merged 7 commits intomainfrom
amanjeev/maintenance-updates

Conversation

@amanjeev
Copy link
Contributor

@amanjeev amanjeev commented Nov 13, 2024

  • Updates dependencies for crates
  • Notably: thiserror to 2.0.3 from 1.
  • Major breaking change for CriticlaUp was:

    Tuple structs and tuple variants can no longer use numerical {0} {1} access at the same time as supplying extra positional arguments for a format message, as this makes it ambiguous whether the number refers to a tuple field vs a different positional arg (Disable numbered access to positional args on tuples dtolnay/thiserror#354)

  • Removes some unused deps.

@amanjeev amanjeev requested a review from Hoverbear November 14, 2024 18:15
@amanjeev amanjeev marked this pull request as ready for review November 14, 2024 18:15
JsonSerialization(#[from] serde_json::Error),

#[error("State file at {} is not supported by this release (state format version {1}).", .0.display())]
#[error("State file at {0} is not supported by this release (state format version {1}).")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am very surprised this works.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know! I was surprised too.

Copy link
Member

@Hoverbear Hoverbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@bors-ferrocene
Copy link
Contributor

Build succeeded:

@bors-ferrocene bors-ferrocene bot merged commit 90a70ce into main Nov 14, 2024
@bors-ferrocene bors-ferrocene bot deleted the amanjeev/maintenance-updates branch November 14, 2024 18:36
aws-smithy-runtime-api = { version = "1.7.3", optional = true }
tokio = { version = "1.37.0", features = ["rt", "rt-multi-thread", "macros"], optional = true }
once_cell = "1.19.0"
reqwest = "0.12.9"
Copy link
Member

@Hoverbear Hoverbear Nov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be:

reqwest.workspace = true

See #68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants