Conversation
Add LDAP and Kerberos schemas and wire up UI to switch provider type via URL query param. Include radio-group component and EmptyStateProviders UI. Add @radix-ui/react-radio-group dependency and update pnpm lockfile.
359feaf to
19f1523
Compare
Return federation provider lists as ListProvidersResponse { data: [...] } and
update the HTTP handler. Update frontend API types, add React Query hooks for
listing/creating/deleting providers, and wire the LDAP create form and overview
page to consume the new response shape and loading state.
Change DELETE /federation/providers/{id} to return a JSON message
instead of 204 and update OpenAPI schema. Add provider detail/edit page,
frontend hooks, routes and delete confirmation flow. Add tracing logs
across core and infrastructure and derive OpenAPI schemas for API
errors.
Extract LdapDetailForm and move data fetching to the parent Compute default form values from providerData and remove the useEffect reset. Introduce useFormChanges to detect edits and pass hasChanges into LdapFormUi. Update FloatingActionBar to show only when editing and the form is valid and has changes. Make priority Select controlled in both LDAP and Kerberos forms and extract mapPriority helper.
LeadcodeDev
approved these changes
Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.