Merged
Conversation
- Add FederationService implementation in core - Add FederationService delegation in ApplicationService - Create DTOs with config sanitization - Implement create, list, get, update, delete handlers - Register routes under /realms/:realm/abyss - Register OpenAPI docs
Add OpenAPI docs and integrate federation handlers under
/realms/{realm_name}/federation. Rename UTOIPA path param from realm to
realm_name, add endpoint summaries, and apply auth middleware. Update
generated frontend client types and endpoints (provider
requests/responses, update provider, userinfo, token fields).
Update FederationService trait and implementations to accept Identity and realm_name for get/delete operations. Adjust HTTP handlers to forward identity and realm_name and remove duplicate realm checks. Change FederationServiceImpl to depend on RealmRepository and FederationRepository, perform realm ownership checks and return Forbidden on mismatch. Add ToSchema to FederationProvider and adapt API responses accordingly.
Add FederationPolicy trait and implement it for FerriskeyPolicy. Enforce policy checks inside FederationServiceImpl and move realm resolution into the service. Thread Identity and realm_name through service APIs and wire the policy into ApplicationService. Update HTTP handlers and frontend client types to match.
Return Response<ProviderResponse> instead of raw domain entities, converting providers to DTOs via into() (including mapping Vec items). Use Response::Created for create handler and clean up related imports.
LeadcodeDev
approved these changes
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.