Skip to content

Comments

feat: add more details to errors#631

Merged
NathaelB merged 1 commit intoferriskey:mainfrom
luisRubiera:fix/611-invalid-error
Jan 10, 2026
Merged

feat: add more details to errors#631
NathaelB merged 1 commit intoferriskey:mainfrom
luisRubiera:fix/611-invalid-error

Conversation

@luisRubiera
Copy link
Contributor

solves #611

@luisRubiera luisRubiera requested a review from NathaelB as a code owner January 1, 2026 09:33
Copy link
Member

@NathaelB NathaelB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LeadcodeDev LeadcodeDev changed the title add more details to errors feat: add more details to errors Jan 1, 2026
@LeadcodeDev LeadcodeDev added this to the v0.3.0 milestone Jan 1, 2026
@LeadcodeDev LeadcodeDev linked an issue Jan 1, 2026 that may be closed by this pull request
@NathaelB
Copy link
Member

NathaelB commented Jan 2, 2026

Hello @luisRubiera , can you signs your commits please ?
image

@luisRubiera luisRubiera force-pushed the fix/611-invalid-error branch from f3368e1 to 137eeb3 Compare January 9, 2026 20:44
@luisRubiera
Copy link
Contributor Author

@NathaelB can you check if now is signed ?

@NathaelB
Copy link
Member

@NathaelB can you check if now is signed ?

It's good

@NathaelB NathaelB merged commit 8924a77 into ferriskey:main Jan 10, 2026
7 checks passed
NathaelB pushed a commit that referenced this pull request Jan 16, 2026
NathaelB added a commit that referenced this pull request Jan 16, 2026
* feat: add ThemeProvider and user theme menu (#651)

* feat: invalid id token field instead embedded into access token (#652)

* feat: refactor token generation and support id_token

Add a new `IdTokenClaims` struct and a `TokenClaims` trait to abstract
over different token claim types. Modify `create_jwt` to optionally
generate an ID token if the `openid` scope is present. Update `JwtToken`
to accommodate an optional ID token.

* fix: refactor token creation to include ID token

* fix: return service account not found exception when service account not found (#611) (#631)

* fix: only validate client secret for non-public clients (#657)

* Fix: only validate client secret for non-public clients

* Fix: Simplify client secret validation logic

---------

Co-authored-by: Luis Daniel RUBIERA <[email protected]>
Co-authored-by: Joris VILARDELL <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Error Mapping Bug in exchange_token Method

3 participants