fix: error when I want setup my totp code#599
Merged
Conversation
Add refetchOnWindowFocus: false to react-query config. Show toast and redirect when OTP setup token is missing and log/setup errors. Show toast on OTP challenge errors, pass isLoading and display a spinner/Signing In... state during OTP submission. Prevent repeated auth-token setting in required-action and render a loading fallback. Hide social login and extra links on the login page.
LeadcodeDev
requested changes
Dec 15, 2025
front/src/pages/authentication/feature/execution/configure-otp-feature.tsx
Outdated
Show resolved
Hide resolved
LeadcodeDev
approved these changes
Dec 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and fixes across the backend authentication logic, TOTP verification, and frontend user experience, particularly around OTP flows. The changes enhance error handling, add support for temporary JWT tokens, improve logging, and refine the frontend OTP and login experience.
Backend: Authentication and JWT Improvements
TemporaryJWT claim type, including a constructor for temporary tokens with a 5-minute expiry.Backend: TOTP Verification Enhancements
DevOps: Docker Compose Configuration
docker-compose.yamlto use consistent ports (3333for API and5555for webapp) and matching environment variables, ensuring local development matches expected endpoints.Frontend: OTP and Authentication UX Improvements
Frontend: Query Behavior