refactor: update core traits for testability and remove unnecessary#499
Merged
refactor: update core traits for testability and remove unnecessary#499
Conversation
Clone bounds - Add `#[cfg_attr(test, mockall::automock)]` to repository traits for easier mocking - Remove `Clone` and `'static` bounds from most service and policy traits - Use `Arc` for repository fields in service structs to enable shared ownership - Update constructors and usages to wrap repositories in `Arc` - Update dependencies and lockfile for mockall and related crates - Add and update test helpers for service layer unit tests
Includes tests for: - ManageRealm permission - Users without realm - Insufficient permissions - No roles assigned - Cross-realm access from master realm
LeadcodeDev
approved these changes
Oct 17, 2025
brogouh
pushed a commit
to brogouh/ferriskey
that referenced
this pull request
Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clone bounds
#[cfg_attr(test, mockall::automock)]to repository traits for easier mockingCloneand'staticbounds from most service and policy traitsArcfor repository fields in service structs to enable shared ownershipArc