Conversation
- Replace use case-based client deletion with direct service call - Introduce DeleteClientInput struct for deletion parameters - Remove delete_client_use_case from UseCaseBundle and factories - Update ClientService trait and implementation to accept DeleteClientInput
Replace use case structs with input structs and update core service trait and implementation to support new handler signatures.
- Remove use-case and orchestrator modules from core - Implement domain service traits in FerriskeyService - Update API handlers to call domain services instead of use-cases - Move credential and user logic into service trait impls - Simplify startup logic to use CoreService trait - Remove unused service and strategy modules - Update imports and wiring throughout application and domain layers
LeadcodeDev
approved these changes
Sep 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.