Skip to content

Comments

Use root as context when running docker compose#306

Merged
NathaelB merged 2 commits intoferriskey:mainfrom
mouhsen-ibrahim:fix/docker-compose-local-build
Aug 11, 2025
Merged

Use root as context when running docker compose#306
NathaelB merged 2 commits intoferriskey:mainfrom
mouhsen-ibrahim:fix/docker-compose-local-build

Conversation

@mouhsen-ibrahim
Copy link
Contributor

This is essential to have the core dependencies available when building the API. Additional points:

  • Copy core/Cargo.toml into the cacher container of the API
  • Fix the copy command for migrations
  • Remove service: 3.8 from the docker compose files, it is deprecated and ignored anyway

This is essential to have the core dependencies available when
building the API. Additional points:
* Copy core/Cargo.toml into the cacher container of the API
* Fix the copy command for migrations
* Remove `service: 3.8` from the docker compose files, it is
deprecated and ignored anyway
Copy link
Member

@NathaelB NathaelB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you !

@NathaelB NathaelB merged commit 337210e into ferriskey:main Aug 11, 2025
1 check passed
@mouhsen-ibrahim mouhsen-ibrahim deleted the fix/docker-compose-local-build branch August 11, 2025 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants