Merged
Conversation
Closed
Contributor
|
@karthik2804 this is a great addition! I added a separate issue #240 to raise the question of how best we could document how the formatting you outlined here (thanks for the example!) can be published for the developer who is writing & editing pages, it's not a blocker for this PR. |
flynnduism
approved these changes
Dec 19, 2022
mikkelhegn
approved these changes
Dec 19, 2022
Member
mikkelhegn
left a comment
There was a problem hiding this comment.
Only approving the description and example. I have not tested the code, nor read it. Consider adding a reviewer to review the JS code.
Contributor
|
@karthik2804 I've reviewed the JS changes and it LGTM! In |
flynnduism
approved these changes
Jan 9, 2023
9aa9a25 to
713a100
Compare
Signed-off-by: karthik Ganeshram <[email protected]>
Signed-off-by: flynnduism <[email protected]> Signed-off-by: karthik Ganeshram <[email protected]>
Signed-off-by: flynnduism <[email protected]> Signed-off-by: karthik Ganeshram <[email protected]>
Signed-off-by: flynnduism <[email protected]> Signed-off-by: karthik Ganeshram <[email protected]>
Signed-off-by: karthik Ganeshram <[email protected]>
713a100 to
be9b87c
Compare
Signed-off-by: karthik Ganeshram <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR also includes the refactoring of the javascript into multiple files for easier maintenance.
Shortcodes need to be enabled in the frontmatter to use multitab.
The markup to create tabs in markdown is as follows