datapack: free all elements on clear (alliedmodders#1251)#1
Merged
fengjixuchui merged 6 commits intofengjixuchui:masterfrom Apr 28, 2020
Merged
datapack: free all elements on clear (alliedmodders#1251)#1fengjixuchui merged 6 commits intofengjixuchui:masterfrom
fengjixuchui merged 6 commits intofengjixuchui:masterfrom
Conversation
Replace StringToLocalUTF8 with LocalToString and memcpy to make this binary compatible and update the documentation.
* Update Function Offsets For PVKII 0.4.2.2 -Updates offsets for Linux/Win/Mac
* Update Function Offsets For PVKII 0.4.2.2 -Updates offsets for Linux/Win/Mac -Update func sig FireOutput for Linux/Win/Mac
* Fixed memory leak When a pack was cleared or destroyed the String and Raw types could cause memory leaks. This happens when "position" is sitting at the end of the vector and can never get past the "if (pos >= elements.length())" statement. This means there is a memory leak in any plugin that clears/destroys a pack with strings and doesn't set the position to length-1 or less beforehand. * datapack: Fix delete op on CDataPackType::Raw. Co-authored-by: Kyle Sanderson <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.