adjusted welcome view layout (MacPass#1101)#1
Merged
fengjixuchui merged 22 commits intofengjixuchui:masterfrom Sep 9, 2020
Merged
adjusted welcome view layout (MacPass#1101)#1fengjixuchui merged 22 commits intofengjixuchui:masterfrom
fengjixuchui merged 22 commits intofengjixuchui:masterfrom
Conversation
* Use DuckDuckGo favicon service There are multiple ways of how favicon of a website can be published: - Have a `favicon.ico` file under the website root - Set through `<link rel="shortcut icon" href="..." />` tag - Set through `<link rel="icon" href="..." />` tag, or - Set through platform-specific tags like `<link rel="apple-touch-icon" href="..." />` Current implementation only supports first option, which does not work in many cases. Instead of implementing favicon fetching logic from scratch, favicon fetching services can be used. There are multiple of them, e.g.: - https://icons.duckduckgo.com/ip3/www.google.com.ico - https://www.google.com/s2/favicons?domain=www.google.com This change switched from fetching favicon from the original host to DuckDuckGo. * Create UX for favicon download method preferences * Add preferences for favicon download method * Adjust preferences window location Also, sort localized resources Co-authored-by: Alex Rakov <[email protected]>
* Ukrainian translations * Typo fixes. Kudos to @troyane * Fix typo in DEFAULT_GROUP_NAME * Fix typos Applied fixes in Localizable.strings, MainMenu.strings, PasswordCreatorView.strings, PluginPreferences.strings. Co-authored-by: Nazar Gerasymchuk <[email protected]>
… our own implementation
…. Now returning empty dictionary instead
…custom-values table view
* Create AutotypeBuilderView.strings * Create AutotypeCandidateSelectionView.strings * Create AutotypeDoctorReportViewController.strings * Create ContextBar.strings * Create DatabaseSettingsWindow.strings * Create DatePickingView.strings * Create DuplicateEntryOptionsWindow.strings * Create EntryInspectorView.strings * Create GeneralPreferences.strings * Create GroupInspectorView.strings * Create IconSelection.strings * Create InfoPlist.strings * Create InspectorView.strings * Create IntegrationPreferences.strings * Create Localizable.strings * Create Localizable.stringsdict * Create MainMenu.strings * Create PasswordCreatorView.strings * Create PasswordEditWindow.strings * Create PasswordInputView.strings * Create PluginDataView.strings * Create PluginPreferences.strings * Create PluginRepositoryBrowserView.strings * Create ReferenceBuilderView.strings * Create SavePanelAccessoryView.strings * Create UpdatePreferences.strings * Create WelcomeView.strings * Create WorkflowPreferences.strings
… required. Added concealed/transient type marker to copied items to enhance compatibility with clipboard managers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.