feat(aes): 💅 improve encryption/decryption with Strings#14
Merged
Conversation
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
felipebonezi
force-pushed
the
feature/refactor-icipher
branch
from
October 21, 2022 12:34
10c0e14 to
9e78a15
Compare
Fixes #3 Signed-off-by: Felipe Bonezi <[email protected]>
felipebonezi
force-pushed
the
feature/refactor-icipher
branch
from
October 21, 2022 12:37
9e78a15 to
6589de4
Compare
felipebonezi
added
type:feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verifique se o PR cumpre os seguintes pontos
What's Changed
✨ New feature
encryptToStringbutStringis not a good container for binary data. Specifically, such a string will almost surely contain unprintable characters, so if you print it or try to pass it via HTML or some other means, you will get some problems (data loss, for example).