chore(cli): add deprecation warnings to hidden global commands - #8416
Merged
dpc merged 1 commit intoMar 25, 2026
Merged
Conversation
Add warn! deprecation messages to all hidden global CLI commands that have module or dev equivalents after fedimint#8340. Also standardize existing eprintln! warnings to use warn!(target: LOG_CLIENT) for consistency. Commands: reissue, spend, split, combine, await-invoice, await-ln-pay, list-gateways, withdraw, deposit-address, await-deposit, config, session-count.
dpc
approved these changes
Mar 25, 2026
This was referenced May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
warn!deprecation messages to all hidden global CLI commands that have module or dev equivalents (introduced in #8340). Also standardize existingeprintln!warnings (deposit-address,await-deposit) to usewarn!(target: LOG_CLIENT, ...)for consistency with the warnings already added in #8340 forln-invoiceandln-pay.Contributes to #3630.
Changes
New deprecation warnings (8 commands):
reissuemodule mint reissuespendmodule mint spendsplitmodule mint splitcombinemodule mint combineawait-invoicemodule ln await-invoiceawait-ln-paymodule ln await-paylist-gatewaysmodule ln list-gatewayswithdrawmodule wallet withdrawStandardized warnings (2 commands):
deposit-addresseprintln!→warn!(target: LOG_CLIENT)await-depositeprintln!→warn!(target: LOG_CLIENT)Dev subcommand warnings (2 commands):
configdev configsession-countdev session-countNotes
discover-versionleft without warning as it has no equivalent indevsubcommandTest plan