Fix environment variable read issues and potential bugs #980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoyongzhu
requested review from
Yuqing-cat,
blrchen,
enya-yx,
jainr,
loomlike and
windoze
xiaoyongzhu
changed the title
Yuqing-cat
reviewed
Jan 18, 2023
Collaborator
|
I see two changes in this PR
1 should be merged to main quickly as it's fixing issue on critial path. 2 might require more manual test and can take some time to get it merged. Can I suggest we split into two PRs so 1 can get merged quickly and make more room for 2 to get tested. |
Member
Author
Good point, this is reverted. |
blrchen
reviewed
Jan 18, 2023
Yuqing-cat
approved these changes
Jan 18, 2023
xiaoyongzhu
added a commit
to xiaoyongzhu/feathr
that referenced
this pull request
Jan 19, 2023
…hr-ai#980)" This reverts commit a9ca048.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few issues, mostly: