Skip to content

Lock python deps versions in sql registry #977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xiaoyongzhu merged 1 commit into from
Jan 17, 2023
Merged

Lock python deps versions in sql registry #977

xiaoyongzhu merged 1 commit into from
Jan 17, 2023

Conversation

@blrchen
Copy link
Collaborator

@blrchen blrchen commented Jan 17, 2023

Description

This PR locks pip version for a few recent new deps

  • cython: according to @enya-yx , this is required for sql registry to work on her dev environment, use latest version
  • pydantic: removed, this is an indirect dep consumed by fastapi.
  • sqlalchemy: this is newly added by @xiaoyongzhu for sandbox support, use latest version.

How was this PR tested?

Does this PR introduce any user-facing changes?

  • No. You can skip the rest of this section.
  • Yes. Make sure to clarify your proposed changes.

@xiaoyongzhu xiaoyongzhu merged commit 2c87b8a into main Jan 17, 2023
@blrchen blrchen deleted the blair/update-deps branch January 17, 2023 14:55
xiaoyongzhu added a commit to xiaoyongzhu/feathr that referenced this pull request Jan 19, 2023
@xiaoyongzhu
Revert "Lock python deps versions in sql registry (feathr-ai#977)"
0b14df1 
This reverts commit 2c87b8a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@windoze windoze windoze approved these changes

@Yuqing-cat Yuqing-cat Yuqing-cat approved these changes

@xiaoyongzhu xiaoyongzhu Awaiting requested review from xiaoyongzhu

@enya-yx enya-yx Awaiting requested review from enya-yx

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@blrchen @windoze @Yuqing-cat @xiaoyongzhu