Add a Sandbox for Feathr #966
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loomlike
reviewed
Jan 14, 2023
Collaborator
loomlike
left a comment
loomlike
left a comment
There was a problem hiding this comment.
This is super cool! I haven't actually run in on my local box yet, but I will try and let you know if I have any issues.
In the meantime, I left some comments as well. Thank you!
Yuqing-cat
reviewed
Jan 16, 2023
Yuqing-cat
previously approved these changes
Jan 17, 2023
enya-yx
reviewed
Jan 17, 2023
blrchen
approved these changes
Jan 17, 2023
Yuqing-cat
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR is to package everything into a single docker image to:
As an end user, they can become productive in less than 5 mins.
Users can try it out by following this doc:
https://xiaoyongzhu.github.io/feathr/quickstart_local_sandbox.html
[x] Currently feature materialization doesn't work in the latest branch, although using Feathr 0.9 it worked in sandbox environment. @Yuqing-cat
[x] There are some potential version conflicts when installing Feathr in Sandbox.
[x] Search functionality in Sandbox doesn't work
[x] Updated README files and instructions for users to get started
[x] Remove login UI for Microsoft account
[x] Remove duplicated code
[x] Make Feathr API auth a bit more configurable
[x] merge the ORM based SQL backend to sql-registry folder