Skip to content

Conversation

@loomlike
Copy link
Collaborator

@loomlike loomlike commented Dec 2, 2022

Signed-off-by: Jun Ki Min [email protected]

Description

This is to fix nightly test failure. Seems the cause was when using online-sink and thus the output_path is None and
Databricks complains about None value tags.

How was this PR tested?

Tested with Databricks nightly test notebook.

Does this PR introduce any user-facing changes?

  • No. You can skip the rest of this section.
  • Yes. Make sure to clarify your proposed changes.

Signed-off-by: Jun Ki Min <[email protected]>
@loomlike loomlike added the safe to test Tag to execute build pipeline for a PR from forked repo label Dec 2, 2022
@xiaoyongzhu xiaoyongzhu merged commit 1233653 into feathr-ai:main Dec 2, 2022
@loomlike loomlike deleted the jumin/fix_empty_job_tag branch December 2, 2022 18:29
jaymo001 pushed a commit that referenced this pull request Dec 7, 2022
Signed-off-by: Jun Ki Min <[email protected]>

Signed-off-by: Jun Ki Min <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Tag to execute build pipeline for a PR from forked repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants