add KeyError for key and feature type #877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuqing Wei <[email protected]>
Yuqing-cat
added
the
safe to test
xiaoyongzhu
approved these changes
Nov 23, 2022
Member
|
The test failure should be unrelated IMO |
blrchen
reviewed
Nov 23, 2022
blrchen
approved these changes
Dec 1, 2022
jaymo001
pushed a commit
that referenced
this pull request
Dec 7, 2022
Signed-off-by: Yuqing Wei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yuqing Wei [email protected]
Description
Resolves #766
How was this PR tested?
Test
test_dtype.pyadded under unit folder with 2 functions:Does this PR introduce any user-facing changes?
User will get KeyError if the type of Key or Feature is not correct.