Fix bug in empty array dense tensor default value #806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoyongzhu
requested review from
d4ve,
hangfei,
jaymo001,
rakeshkashyap123 and
shashankiiit
xiaoyongzhu
added
the
safe to test
xiaoyongzhu
approved these changes
Nov 1, 2022
jaymo001
approved these changes
Nov 1, 2022
d4ve
approved these changes
Nov 1, 2022
rakeshkashyap123
approved these changes
Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix bug in empty default value array. Currently the return value of an empty dense tensor is a UniversalTensor and not a DenseTensor which breaks our default value code. To address this we can include the type information of the field when we try to do tensor conversion which allows the correct empty array to be created.
How was this PR tested?
Added new test case in AnchoredFeaturesIntegTest and tested via following command
sbt "testOnly *AnchoredFeaturesIntegTest" -java-home /Library/Java/JavaVirtualMachines/jdk1.8.0_282-msft.jdk/Contents/HomeDoes this PR introduce any user-facing changes?
No