Skip to content

Conversation

@blrchen
Copy link
Collaborator

@blrchen blrchen commented Oct 28, 2022

Description

This PR reverts pytest-xdist added by PR #773, with pytest-xdist, now ci tests fail with Different tests were collected between gw4 and gw5.

For more details please read: pytest-dev/pytest-xdist#432

After discussing with @loomlike , the root cause is in following code, NamedTemporaryFile().name confuses xdist. He will submit a right fix to mitigate this issue.

@pytest.mark.parametrize(
    "output_filepath", [None, NamedTemporaryFile().name],
)
def test__generate_config

How was this PR tested?

Does this PR introduce any user-facing changes?

  • No. You can skip the rest of this section.
  • Yes. Make sure to clarify your proposed changes.

@blrchen blrchen added the work-in-progress/do-not-merge Work in Progress PR, do not merge label Oct 28, 2022
@blrchen blrchen closed this Oct 29, 2022
@blrchen blrchen deleted the blair/revert-pytest-xdist branch October 31, 2022 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

work-in-progress/do-not-merge Work in Progress PR, do not merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants