Skip to content

Conversation

@hyingyang-linkedin
Copy link
Contributor

Description

This RB is the following RB of Add Data Models
Based on doc

Changes in this RB:

Add attributes to data models

Update data model diagram to reflect attributes changes

How was this PR tested?

N/A

Does this PR introduce any user-facing changes?

  • [x ] No. You can skip the rest of this section.
  • Yes. Make sure to clarify your proposed changes.

@blrchen blrchen requested review from LeBenHL and windoze October 21, 2022 13:15
ahlag and others added 13 commits October 25, 2022 15:29
* Added _scproxy necessary for MacOS

Signed-off-by: changyonglik <[email protected]>

* Changed to conditional import

Signed-off-by: changyonglik <[email protected]>

* Added comments

Signed-off-by: changyonglik <[email protected]>

Signed-off-by: changyonglik <[email protected]>
* Create consume-features.md

* Update consume-features.md

* rename docs

* Update model-inference-with-feathr.md

* Update README.md

* update docs per feedback

* Update streaming-source-ingestion.md

* update docs

* update docs

* Update azure-deployment-arm.md

* Update model-inference-with-feathr.md

* add sign off message

Signed-off-by: Xiaoyong Zhu [email protected]

* fix comments

* Delete deploy-feathr-api-as-webapp.md

* Update model-inference-with-feathr.md

Signed-off-by: Xiaoyong Zhu [email protected]
* Clean up after moving to LFAI

Clean up after moving to LFAI

* Update README.md
…image (feathr-ai#668)

* Adding DevSkim linter to Github actions

* Fix in ARM template to pull latest tagged release image from dockerhub

* Removing dev skim file from this branch

* Fixing linkedin org reference
* Added prettier documentation

Signed-off-by: changyonglik <[email protected]>

* Fixed prettier documentation

Signed-off-by: changyonglik <[email protected]>

Signed-off-by: changyonglik <[email protected]>
* squash commit and avoid conflict

* Revert legacy purview client issue

* Fix typo

* Remove auth from assink

* Update aerospike guidance document

* Chaneg port param to int
* extend rbac to support project id as input

Signed-off-by: Yuqing Wei <[email protected]>

* update registry docs and interface

Signed-off-by: Yuqing Wei <[email protected]>

* user name case sensitive hot fix

Signed-off-by: Yuqing Wei <[email protected]>

Signed-off-by: Yuqing Wei <[email protected]>
…al spark (feathr-ai#644)

* local spark feature join job with local file

* update local spark with udf support

* add feature gen support in local spark

* update test case

* remove unused feature conf, update doc

* expose master as input and refine local spark provider

Signed-off-by: Yuqing Wei <[email protected]>
…hr-ai#686)

Fixes feathr-ai#685
Look at the screenshot in the issue with the fixes.

Basically it seems for dockerhub images, we don't need to pass in the full URL (domain name) for the image name while publishing them to webapps.
* Update setup.py

* Update setup.py

* Update setup.py
…#667)

* Apply 'aggregation_features' parameter to merge dataframes

* modify test cases

* modify test case filter rule to keep same results as before

* add typekey check and improve previous changes

* merge to main and quick change

* revert change by mistake

* Apply this parameter to HDSF sink and add comments

* quick fix

* quick improve

Co-authored-by: Enya-Yx <[email protected]>
Co-authored-by: enya-yx <[email protected]>
Co-authored-by: enya-yx <[email protected]>
Fendoe and others added 19 commits October 25, 2022 15:32
* Fix icons in UI cannot auto scale (feathr-ai#737)

* Fix home.css code style issue
* Expose 'timePartitionPattern'

* add test case

* Add test cases and docstring

* delete local files

* quick fix

Co-authored-by: enya-yx <[email protected]>
Co-authored-by: enya-yx <[email protected]>
* Update materializing-features.md

* Update materializing-features.md
* Fix protobuf version

* quick fix

Co-authored-by: enya-yx <[email protected]>
* Add some notes based on on-call issues

* quick fix

Co-authored-by: enya-yx <[email protected]>
…nd msrest (feathr-ai#763)

* Adding DevSkim linter to Github actions

* Fix in ARM template to pull latest tagged release image from dockerhub

* Removing dev skim file from this branch

* Fixing linkedin org reference

* Removing the docker index url from dockerhub image name as it seems to cause problem with the update

* Adding to the right file, had a dockerhub workflow file with different name

* Adding debug statements to test udf issue on Synapse

* Adding more print statements

* Pinning msrest version to work with pinned version of azure-core

* Removing debug code from previous branch
…thr-ai#746)

* unify python package version and enable env setting for scala version

Signed-off-by: Yuqing Wei <[email protected]>

* update docs and decouple maven version

Signed-off-by: Yuqing Wei <[email protected]>

* change version back to 0.8.0 to avoid conflicts

Signed-off-by: Yuqing Wei <[email protected]>

* fix typo

Signed-off-by: Yuqing Wei <[email protected]>

Signed-off-by: Yuqing Wei <[email protected]>
* Add flag to enable generation non-agg features

* Typo

* Resolve comments
* Adding DevSkim linter to Github actions

* Update docker-publish.yml

* Update docker-publish.yml

* Update docker-publish.yml

* Update docker-publish.yml

* Update docker-publish.yml

* Update docker-publish.yml

* Update docker-publish.yml

* Update docker-publish.yml

* Removing devskim file

* Restructuring the Prod Reco sample

* Adjusting headings

* Minor changes

* Removing changes to docker publish file

* Addressing PR comments, moving Product recommendation notebook sample to Synapse folder since it is strongly tied to Synapse

* Addressing PR comments

* Fixing images

* Removing the need to pass email id as we could directly compute object Id using az command, also making CLI instructions clearer that it is for advance users
* Update role-management page in UI (feathr-ai#751)

* fix home.css LF file

* fix RoleForm eslint warning

* remove import dayjs

Signed-off-by: Boli Guan <[email protected]>

* Change components to arrow function.

Signed-off-by: Boli Guan <[email protected]>

Signed-off-by: Boli Guan <[email protected]>
* Add craco devDependencies

Signed-off-by: Boli Guan <[email protected]>

* Add classnames, @ant-design/icons,eslint-plugin.. dependencies.

Signed-off-by: Boli Guan <[email protected]>

* Update .editorconfig and .eslintrc

* Update .editorconfig

Signed-off-by: Boli Guan <[email protected]>

Signed-off-by: Boli Guan <[email protected]>
…to the test pipeline yml (feathr-ai#773)

Signed-off-by: Jun Ki Min <[email protected]>

Signed-off-by: Jun Ki Min <[email protected]>
* Update _databricks_submission.py

* Update feathr-configuration-and-env.md

* Update feathr-configuration-and-env.md

* Update _databricks_submission.py
Copy link
Member

@windoze windoze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked into the updated model classes, they look good to me.

@windoze windoze merged commit be6fa17 into feathr-ai:main Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.