Skip to content

Use maven based submission by default for samples #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xiaoyongzhu merged 3 commits into from
Aug 25, 2022
Merged

Use maven based submission by default for samples #603

xiaoyongzhu merged 3 commits into from
Aug 25, 2022

Conversation

@xiaoyongzhu
Copy link
Member

@xiaoyongzhu xiaoyongzhu commented Aug 24, 2022 •
edited
Loading

Description

This PR has a few improvements:

  1. Use Maven jar version 0.6.2 for submission
  2. delete all the feathr_runtime_location in the samples so that users don't use them in the future. By removing the feathr_runtime_location config, Feathr will automatically using jars from maven.
  3. Format the notebook to JSON to make it easier for future review

How was this PR tested?

Does this PR introduce any user-facing changes?

  • No. You can skip the rest of this section.
  • Yes. Make sure to clarify your proposed changes.

@xiaoyongzhu xiaoyongzhu added the safe to test Tag to execute build pipeline for a PR from forked repo label Aug 24, 2022
@xiaoyongzhu xiaoyongzhu requested review from Yuqing-cat, blrchen and jainr and removed request for Yuqing-cat, blrchen and jainr August 24, 2022 15:33
@xiaoyongzhu xiaoyongzhu changed the title use maven based submission by default Use maven based submission by default for samples Aug 24, 2022
@jainr
Copy link
Collaborator

jainr commented Aug 24, 2022

How does the notebook get the jar from maven?

@xiaoyongzhu xiaoyongzhu merged commit bf7993e into feathr-ai:main Aug 25, 2022
@xiaoyongzhu
Copy link
Member Author

xiaoyongzhu commented Aug 25, 2022

2. By removing the feathr_runtime_location config, Feathr will automatically using jars from maven.

Yeah if the feathr_runtime_location config is not set, Feathr will automatically using jars from maven.

@xiaoyongzhu xiaoyongzhu mentioned this pull request Aug 25, 2022
Closed
ahlag pushed a commit to ahlag/feathr that referenced this pull request Aug 26, 2022
@xiaoyongzhu @ahlag
Use maven based submission by default for samples (feathr-ai#603)
f57e460 
* use maven based submission by default

* Update Customer360.ipynb

* Update product_recommendation_demo_advanced.ipynb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blrchen blrchen blrchen approved these changes

@jainr jainr jainr approved these changes

@Yuqing-cat Yuqing-cat Awaiting requested review from Yuqing-cat

Assignees

No one assigned

Labels

safe to test Tag to execute build pipeline for a PR from forked repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xiaoyongzhu @jainr @blrchen