Generic Input/Output of DataFrames #475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoyongzhu
reviewed
Jul 15, 2022
Member
|
This PR looks good to me and is a good way of extending to other sources in the future. Thanks @windoze for the work! |
xiaoyongzhu
reviewed
Jul 15, 2022
windoze
added
the
safe to test
jaymo001
reviewed
Jul 26, 2022
src/main/scala/com/linkedin/feathr/offline/config/location/DataLocation.scala
Show resolved
Hide resolved
src/main/scala/com/linkedin/feathr/offline/config/location/GenericLocation.scala
Show resolved
Hide resolved
src/main/scala/com/linkedin/feathr/offline/config/location/GenericLocation.scala
Show resolved
Hide resolved
src/main/scala/com/linkedin/feathr/offline/config/location/GenericLocation.scala
Show resolved
Hide resolved
src/main/scala/com/linkedin/feathr/offline/config/location/GenericLocation.scala
Show resolved
Hide resolved
Yuqing-cat
approved these changes
Aug 13, 2022
blrchen
approved these changes
Aug 13, 2022
ahlag
pushed a commit
to ahlag/feathr
that referenced
this pull request
Aug 26, 2022
* GenericLocation for DataFrame read/write * WIP * Generate id column * Fix unit test * Parse string into DataLocation * Id column must be string * Fix auth logic * Fix unit test * Fix id column generation * CosmosDb Sink
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
InputLocationclasses to support both read and write functions, also renamed it toDataLocationto reflect this change.GenericLocationwhich supports all Spark confs, modes, and options, so it can be used to operate virtually any connectors supported by SparkGenericLocation, I added a format-specific patching mechanism to workaround quirks come with different connectors, e.g. CosmosDb requires rows to have anidcolumn with unique values.FeathrGenJobandFeathrJoinJob, enabling them to use a JSON-encoded string ofDataLocationinstead of plainpathas the input and output target.Theoretically, Feathr core can support all Spark connectors with this patch, but we still run a series of compatibility tests to confirm the final list.
NOTE: This PR only involves Feathr core, the corresponding Feathr Client changes will be in upcoming PRs.