Allow FeathrClient to interact with updated registry schema #466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoyongzhu
added
work-in-progress/do-not-merge
xiaoyongzhu
reviewed
Jul 19, 2022
Yuqing-cat
reviewed
Jul 26, 2022
windoze
added
the
safe to test
jainr
previously approved these changes
Jul 26, 2022
xiaoyongzhu
reviewed
Jul 26, 2022
xiaoyongzhu
reviewed
Jul 26, 2022
Member
|
Also seems test is failed? Can you fix those? https://github.com/linkedin/feathr/runs/7518222803?check_suite_focus=true |
Yuqing-cat
previously approved these changes
Jul 27, 2022
xiaoyongzhu
changed the title
xiaoyongzhu
approved these changes
Jul 27, 2022
Yuqing-cat
approved these changes
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix get feature from registry
Make the old client work with new schema