Skip to content

Conversation

@windoze
Copy link
Member

@windoze windoze commented Jun 23, 2022

SQL registry now support entity creation.
Before this PR the SQL registry solely worked with UI without creating functions.

YihuiGuo
YihuiGuo previously approved these changes Jun 23, 2022
Copy link
Collaborator

@Yuqing-cat Yuqing-cat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very important prerequisite PR for access control features. Very helpful enhancement.
I would suggest moving database.py to a common folder under /registry so that sql-based access control can reuse it.
Also, are the interface.py and models.py a common description for all backend registries? If so, shall we move those common definition outside of sql-registry?

@windoze
Copy link
Member Author

windoze commented Jun 24, 2022

This is a very important prerequisite PR for access control features. Very helpful enhancement. I would suggest moving database.py to a common folder under /registry so that sql-based access control can reuse it. Also, are the interface.py and models.py a common description for all backend registries? If so, shall we move those common definition outside of sql-registry?

I plan to submit another following up PR for re-structuring, don't want to mess up before function stabilization.

Yuqing-cat
Yuqing-cat previously approved these changes Jun 24, 2022
@Yuqing-cat
Copy link
Collaborator

plan to submit another following up PR for re-structuring, don't want to mess up before function stabilization.

Agree, I can also help to do this my access control PR.

@YihuiGuo YihuiGuo mentioned this pull request Jun 26, 2022
@xiaoyongzhu xiaoyongzhu deleted the windoze/sql-registry-create branch August 22, 2022 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants