Skip to content

enable JWT token param in frontend API calls #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Yuqing-cat merged 4 commits into from
Jun 14, 2022
Merged

enable JWT token param in frontend API calls #337

Yuqing-cat merged 4 commits into from
Jun 14, 2022

Conversation

@Yuqing-cat
Copy link
Collaborator

@Yuqing-cat Yuqing-cat commented Jun 9, 2022

  • Enable JWT token to replace current hardcode mock token.
  • Protect all API calls with JWT token
  • Abstract MsalInstance logic into utils.tsx

@Yuqing-cat Yuqing-cat linked an issue Jun 9, 2022 that may be closed by this pull request
enable JWT token Param in frontend API calls #336
Closed
blrchen
blrchen reviewed Jun 9, 2022
View reviewed changes
blrchen
blrchen reviewed Jun 9, 2022
View reviewed changes
blrchen
blrchen reviewed Jun 9, 2022
View reviewed changes
blrchen
blrchen approved these changes Jun 9, 2022
View reviewed changes
Copy link
Collaborator

@blrchen blrchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Yuqing-cat Yuqing-cat added the safe to test Tag to execute build pipeline for a PR from forked repo label Jun 10, 2022
@Yuqing-cat Yuqing-cat linked an issue Jun 10, 2022 that may be closed by this pull request
Add azure ad authentication to Fast API #295
Closed
@jainr jainr requested review from jainr and jaymo001 June 13, 2022 15:14
@Yuqing-cat Yuqing-cat merged commit dff6a0d into feathr-ai:main Jun 14, 2022
bozhonghu pushed a commit that referenced this pull request Jun 15, 2022
@bobohu97
Merge branch 'main' into fcm_feathr_merge
0f7aa13 
* main:
  Fixing purview test issues and improve performance (#350)
  [feathr] Add product_recommendation advanced sample (#348)
  obejectId query cmd update (#360)
  add license, release, docs, python api ref badges with shields img (#357)
  quick fix the 404 not found in read me link (#355)
  Python SQL Registry (#311)
  enable JWT token param in frontend API calls (#337)
  Optimize environment variable behavior (#333)
  Adding better warning message to let user know that config file is missing and they need to set env parameters. (#347)
  Feature Monitoring (#330)
  Windoze/211 maven submission (#334)
  Windoze/211 maven submission (#334)
  Windoze/211 maven submission (#334)
  Fix Synapse quickstart link (#346)
  Show feature details when click feature in lineage graph (#339)
  Update pull_request_push_test.yml
  Update UI README for how to create overrides for local development (#335)
  Update databricks quick start experience (#217)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xiaoyongzhu xiaoyongzhu xiaoyongzhu approved these changes

@blrchen blrchen blrchen approved these changes

@windoze windoze Awaiting requested review from windoze

@hangfei hangfei Awaiting requested review from hangfei

@jainr jainr Awaiting requested review from jainr

@jaymo001 jaymo001 Awaiting requested review from jaymo001

Assignees

No one assigned

Labels

safe to test Tag to execute build pipeline for a PR from forked repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

enable JWT token Param in frontend API calls Add azure ad authentication to Fast API

3 participants

@Yuqing-cat @xiaoyongzhu @blrchen