Optimize environment variable behavior #333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoyongzhu
requested review from
Yuqing-cat,
blrchen,
hangfei,
jainr and
jaymo001
Yuqing-cat
reviewed
Jun 10, 2022
blrchen
reviewed
Jun 10, 2022
blrchen
reviewed
Jun 10, 2022
blrchen
reviewed
Jun 10, 2022
blrchen
reviewed
Jun 10, 2022
blrchen
reviewed
Jun 10, 2022
blrchen
reviewed
Jun 10, 2022
hangfei
reviewed
Jun 10, 2022
blrchen
added
the
safe to test
blrchen
reviewed
Jun 13, 2022
blrchen
approved these changes
Jun 14, 2022
hangfei
approved these changes
Jun 14, 2022
bozhonghu
pushed a commit
that referenced
this pull request
Jun 15, 2022
* main: Fixing purview test issues and improve performance (#350) [feathr] Add product_recommendation advanced sample (#348) obejectId query cmd update (#360) add license, release, docs, python api ref badges with shields img (#357) quick fix the 404 not found in read me link (#355) Python SQL Registry (#311) enable JWT token param in frontend API calls (#337) Optimize environment variable behavior (#333) Adding better warning message to let user know that config file is missing and they need to set env parameters. (#347) Feature Monitoring (#330) Windoze/211 maven submission (#334) Windoze/211 maven submission (#334) Windoze/211 maven submission (#334) Fix Synapse quickstart link (#346) Show feature details when click feature in lineage graph (#339) Update pull_request_push_test.yml Update UI README for how to create overrides for local development (#335) Update databricks quick start experience (#217)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it's a bit confusing for end users and there are multiple asks on what are all the user configurable environment variables (and the expected behaviors).
Also, we only read a portion of the env variables in key vault, but we should actually support reading all the env variables in KV.
This PR solves the above issues, by having a clear logic on how to get the env variables in the following order:
Also add docs describing all the env variables.