Yihui/moderate registration conflict #304
Merged
+180
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Related issue: #263 |
xiaoyongzhu
added
the
safe to test
xiaoyongzhu
reviewed
May 31, 2022
xiaoyongzhu
approved these changes
Jun 1, 2022
jaymo001
reviewed
Jun 1, 2022
Yuqing-cat
approved these changes
Jun 1, 2022
Collaborator
Yuqing-cat
left a comment
Yuqing-cat
left a comment
There was a problem hiding this comment.
Looks good to me as a short-term fix.
bozhonghu
pushed a commit
that referenced
this pull request
Jun 1, 2022
* main: (30 commits) Yihui/moderate registration conflict (#304) Update homepage (#310) Add extensible extractor APIs (#302) Remove Java and JS from Code Scanning Create codeql-analysis.yml [feathr] Add API to materialize features to offline store (#294) Improve error message when path is not supported (#257) Add tech talk slides for Feathr (#296) Update README.md Add milestone link (#286) Fix millisecond timestamp handling (#288) Consolidating CI pipelines (#280) Fixed dependecy problem of pretty print utils (#273) Fixing a broken link in README.md (#277) Fix test failure (#276) Added feature validation (#258) Feathr UI: Display feature key and transform expression in feature detail pages (#262) Feathr UI: enable multiple tenant auth (#266) Reduce feathr web api docker image build time (#261) Pretty-print the features produced by buildFeatures (#214) ...
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges existing anchor with new anchor during registration in order to fix concurrent conflict.
Will serve as a quick fix, but will not solved it entirely.
Full fix will work with MVCC, and is in progress.
The use case is :