Skip to content

Conversation

@jaymo001
Copy link
Collaborator

@jaymo001 jaymo001 commented May 20, 2022

The current SWA code does not support timestamp with millisecond, e.g. 2019-05-03T15:00:00.123Z

@jaymo001 jaymo001 added the safe to test Tag to execute build pipeline for a PR from forked repo label May 20, 2022
@jaymo001 jaymo001 requested review from hangfei and xiaoyongzhu May 20, 2022 18:47
@hangfei
Copy link
Collaborator

hangfei commented May 20, 2022

Could you explain the bug in the description?

@xiaoyongzhu xiaoyongzhu removed the safe to test Tag to execute build pipeline for a PR from forked repo label May 20, 2022
@xiaoyongzhu
Copy link
Member

we don't have to add safe-to-test label now if it's not a forked repo now.

@xiaoyongzhu xiaoyongzhu merged commit 28e1f9d into main May 20, 2022
@xiaoyongzhu xiaoyongzhu deleted the fixTimestamp branch May 20, 2022 19:09
@xiaoyongzhu xiaoyongzhu mentioned this pull request May 20, 2022
bozhonghu pushed a commit that referenced this pull request Jun 1, 2022
* main: (30 commits)
  Yihui/moderate registration conflict (#304)
  Update homepage (#310)
  Add extensible extractor APIs (#302)
  Remove Java and JS from Code Scanning
  Create codeql-analysis.yml
  [feathr] Add API to materialize features to offline store (#294)
  Improve error message when path is not supported (#257)
  Add tech talk slides for Feathr (#296)
  Update README.md
  Add milestone link (#286)
  Fix millisecond timestamp handling (#288)
  Consolidating CI pipelines (#280)
  Fixed dependecy problem of pretty print utils (#273)
  Fixing a broken link in README.md (#277)
  Fix test failure (#276)
  Added feature validation (#258)
  Feathr UI: Display feature key and transform expression in feature detail pages (#262)
  Feathr UI: enable multiple tenant auth (#266)
  Reduce feathr web api docker image build time (#261)
  Pretty-print the features produced by buildFeatures  (#214)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants