Skip to content

Improve Feature Registry Usability #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xiaoyongzhu merged 15 commits into from
May 9, 2022
Merged

Improve Feature Registry Usability #230

xiaoyongzhu merged 15 commits into from
May 9, 2022

Conversation

@xiaoyongzhu
Copy link
Member

@xiaoyongzhu xiaoyongzhu commented May 6, 2022 •
edited
Loading

Goal of this PR is to solve some critical issues that the previous PR by @YihuiGuo didn't address. More specifically, it includes:

  • Getting all the components from the registry back, including the correct keys, Transformation functions, UDFs, etc.
  • Adding a feature_config field in the schema to enable further extensibility
  • Fix a few grammar issues in Python objects, otherwise they won't pass pylint
  • Adding test to make sure that the features returned from the registry can actually run a job

@xiaoyongzhu xiaoyongzhu added the safe to test Tag to execute build pipeline for a PR from forked repo label May 6, 2022
@xiaoyongzhu xiaoyongzhu changed the title Update test_feature_registry.py Fix failures in registry failures May 6, 2022
hangfei
hangfei reviewed May 7, 2022
View reviewed changes
jaymo001
jaymo001 reviewed May 7, 2022
View reviewed changes
@xiaoyongzhu xiaoyongzhu changed the title Fix failures in registry failures Improve Feature Registry Usability May 7, 2022
hangfei
hangfei previously approved these changes May 7, 2022
View reviewed changes
@xiaoyongzhu xiaoyongzhu merged commit ec65efc into main May 9, 2022
@xiaoyongzhu xiaoyongzhu deleted the xiaoyzhu/fix_registry_ci_failure branch May 9, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hangfei hangfei hangfei approved these changes

@jaymo001 jaymo001 jaymo001 approved these changes

Assignees

No one assigned

Labels

safe to test Tag to execute build pipeline for a PR from forked repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xiaoyongzhu @hangfei @jaymo001