Upgrade log4j from 1.x to 2.x #1031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yuqing-cat
requested review from
jainr,
rakeshkashyap123,
windoze and
xiaoyongzhu
Yuqing-cat
added
the
safe to test
windoze
previously approved these changes
Feb 3, 2023
windoze
previously approved these changes
Feb 3, 2023
Signed-off-by: Yuqing Wei <[email protected]>
jainr
previously approved these changes
Feb 3, 2023
Collaborator
|
Do you know why we suddenly started getting this error, does old version of log4j does not work with some of the other new dependencies? |
Member
Log4j 2 introduces some breaking API changes, I've updated all places that use it. |
blrchen
approved these changes
Feb 6, 2023
windoze
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yuqing Wei [email protected]
Description
Resolves #1030
How was this PR tested?
local spark is using
log4j 2.17.2Does this PR introduce any user-facing changes?