Adding dummy entries to feathr_config.yaml file for additional library entries #1012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… config, and also adding additonal entries to reference feathr_config.yaml file so array is initialized assize 2 if users are just copying from it. Also made a note of the error in the code
jainr
requested review from
Yuqing-cat,
edwincheung,
mufajjul and
xiaoyongzhu
xiaoyongzhu
approved these changes
Jan 27, 2023
jainr
added
the
safe to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding placeholder in feathr_config.yaml file for additional libraries to be passed for databricks.
This is needed since we are now passing more than one library to databricks spark config. Also made a note of the error that folks will get if the size is not defined correctly.
Resolves #1009
How was this PR tested?
Tested it in databricks notebook where I was getting list Index out of bounds exception since the spark config library size was 1.
Does this PR introduce any user-facing changes?