-
Notifications
You must be signed in to change notification settings - Fork 1.3k
feat: Add 'swords' icon #823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #823 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 5 5
Lines 34 34
Branches 3 3
=====================================
Hits 34 34Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't really look like Feather.
And we don't have a sword icon already, so this isn't much logical. Don't think only about your use case, but also to other people's
don't know what u mean by it doesn't look feather to you... think it fits pretty well and followed the style guide :) |
|
Ok, but maybe make the |
Thanks for the kind words @locness3 😊
I agree, the thickness of the |
Closes #220