Skip to content

Conversation

@imlinus
Copy link

@imlinus imlinus commented Jan 15, 2020

No description provided.

@imlinus imlinus mentioned this pull request Jan 15, 2020
@codecov
Copy link

codecov bot commented Jan 15, 2020

Codecov Report

Merging #813 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #813   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines          34     34           
  Branches        3      3           
=====================================
  Hits           34     34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91118a6...fcd9091. Read the comment docs.

Copy link

@moeenio moeenio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks weird on the github preview :/ Also, why are you modifying the twitch icon too?
Screenshot_2020-01-15 Feat dice icon by imlinus · Pull Request #813 · feathericons feather

Copy link

@n1ru4l n1ru4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2020-05-28 at 18 01 09

The SVG seems okay when opened within chrome. But looks weird when rendered as a react component (the same as it looks like on Github preview)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants