Skip to content

Conversation

@jletey
Copy link

@jletey jletey commented Jul 21, 2019

Closes #198

@codecov
Copy link

codecov bot commented Jul 21, 2019

Codecov Report

Merging #692 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #692   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines          34     34           
  Branches        3      3           
=====================================
  Hits           34     34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c64e93...cdef986. Read the comment docs.

@mittalyashu
Copy link
Contributor

All those icons look good.

@johnletey did you try to keep spacing b/w the user avatar with the outer circle as the Feather guidelines say.

@moeenio
Copy link

moeenio commented Jul 22, 2019

@johnletey did you try to keep spacing b/w the user avatar with the outer circle as the Feather guidelines say.

Said before the spacing rule in #171 : "These are general guidelines that help create consistency but can be broken on a case-by-case basis.".
I think no spacing is needed here.

@jletey
Copy link
Author

jletey commented Jul 22, 2019

I agree with @locness3 ... I will not add spacing here!

manuelosorio added a commit to manuelosorio/Listet_Frontend that referenced this pull request Jul 12, 2021
Uses icon from feather icons pull request: [#692](feathericons/feather#692)
manuelosorio added a commit to manuelosorio/Listet_Frontend that referenced this pull request Aug 3, 2021
Uses icon from feather icons pull request: [#692](feathericons/feather#692)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Icon Request: User in Circle

3 participants