Skip to content

Conversation

@ahtohbi4
Copy link
Contributor

@ahtohbi4 ahtohbi4 commented Jul 3, 2019

Closes #557

@codecov
Copy link

codecov bot commented Jul 3, 2019

Codecov Report

Merging #659 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #659   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines          34     34           
  Branches        3      3           
=====================================
  Hits           34     34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c64e93...febf875. Read the comment docs.

Copy link

@moeenio moeenio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Myabe rename to HD

@ahtohbi4
Copy link
Contributor Author

ahtohbi4 commented Jul 3, 2019

Myabe rename to HD

Why not? Done.

@moeenio
Copy link

moeenio commented Jul 3, 2019

Excuse me, but what is git force-pushing ?

@ahtohbi4
Copy link
Contributor Author

ahtohbi4 commented Jul 3, 2019

By the force-push I am rewriting my previous commit for clean Git-history (one feature - one commit).

@moeenio
Copy link

moeenio commented Jul 3, 2019

Thanks for the tip 😉

Copy link
Contributor

@MarcelloTheArcane MarcelloTheArcane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericfennis
Copy link

ericfennis commented Jun 23, 2020

@ahtohbi4 Nice icon do you mind if we use your icon in @featherity, or maybe you want to open a PR by yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Icon Request: HD icon

4 participants