Feature: Add icon wallet #658
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #658 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 5 5
Lines 34 34
Branches 3 3
=====================================
Hits 34 34Continue to review full report at Codecov.
|
moeenio
approved these changes
Jul 3, 2019
sebastienlabine
approved these changes
Jul 11, 2019
Contributor
|
Copy pasted the SVG to design tool
|
|
That's a Figma bug. It auto-connects the non-ended paths for some reason. |
edwinvdpol
approved these changes
Dec 12, 2019
jakeleboeuf
reviewed
Apr 16, 2020
Comment on lines
+1
to
+13
| <svg | ||
| xmlns="http://www.w3.org/2000/svg" | ||
| width="24" | ||
| height="24" | ||
| viewBox="0 0 24 24" | ||
| fill="none" | ||
| stroke="currentColor" | ||
| stroke-width="2" | ||
| stroke-linecap="round" | ||
| stroke-linejoin="round" | ||
| > | ||
| <path d="M3 6v12c0 1.1.9 2 2 2h16v-4M3 6c0 1.1.9 2 2 2h14M3 6c0-1.1.9-2 2-2h14v4m0 0h2v4M16 14c0-1.1.9-2 2-2h4v4h-4a2 2 0 0 1-2-2z" /> | ||
| </svg> |
There was a problem hiding this comment.
Updated the paths to draw correctly in Figma:
Suggested change
| <svg | |
| xmlns="http://www.w3.org/2000/svg" | |
| width="24" | |
| height="24" | |
| viewBox="0 0 24 24" | |
| fill="none" | |
| stroke="currentColor" | |
| stroke-width="2" | |
| stroke-linecap="round" | |
| stroke-linejoin="round" | |
| > | |
| <path d="M3 6v12c0 1.1.9 2 2 2h16v-4M3 6c0 1.1.9 2 2 2h14M3 6c0-1.1.9-2 2-2h14v4m0 0h2v4M16 14c0-1.1.9-2 2-2h4v4h-4a2 2 0 0 1-2-2z" /> | |
| </svg> | |
| <svg width="21" height="18" viewBox="0 0 21 18" fill="none" xmlns="http://www.w3.org/2000/svg"> | |
| <path d="M1 3V15C1 16.1 1.9 17 3 17H19V13M1 3C1 4.1 1.9 5 3 5H17M1 3C1 1.9 1.9 1 3 1H17V5M17 5H19V9M14 11C14 9.9 14.9 9 16 9H20V13H16C15.4696 13 14.9609 12.7893 14.5858 12.4142C14.2107 12.0391 14 11.5304 14 11Z" stroke="black" stroke-width="2" stroke-linecap="round" stroke-linejoin="round"/> | |
| </svg> |
There was a problem hiding this comment.
The viewBox is 21x18px here. Needs to be a 24px frame
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17