feat: Add campsite icon
#651
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #651 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 5 5
Lines 34 34
Branches 3 3
=====================================
Hits 34 34Continue to review full report at Codecov.
|
moeenio
previously approved these changes
Jul 2, 2019
Contributor
|
Not sure, if it will work. But here's my suggestion
|
|
The current one is good. |
Author
|
@locness3 @mittalyashu I kind of like Yashu's suggestion ... should I change? |
|
idk |
Author
|
@locness3 I like @mittalyashu's version better ... I have updated the icon! |
moeenio
previously approved these changes
Jul 22, 2019
moeenio
left a comment
moeenio
left a comment
There was a problem hiding this comment.
Maybe having the two versions (your one and @mittalyashu's) ?
Author
|
@locness3 Done! |
moeenio
previously approved these changes
Jul 22, 2019
moeenio
left a comment
moeenio
left a comment
There was a problem hiding this comment.
maybe using the 2 name for yours and the one for @mittalyashu's ?
moeenio
approved these changes
Jul 22, 2019
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #61