Repository navigation
ci: Restore AWS credentials after DynamoDB versioning tests - #7140
Open
franciscojavierarceo wants to merge 1 commit into
Open
franciscojavierarceo wants to merge 1 commit into
franciscojavierarceo wants to merge 1 commit into
Conversation
Signed-off-by: Francisco Javier Arceo <[email protected]>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7140 +/- ##
=======================================
Coverage 52.29% 52.29%
=======================================
Files 459 459
Lines 58090 58090
Branches 8560 8560
=======================================
Hits 30381 30381
Misses 25629 25629
Partials 2080 2080
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Master's Python 3.11 and 3.12 integration jobs fail in Redshift and DynamoDB tests with invalid AWS credentials even though the workflow's initial STS authentication succeeds. The moto-backed DynamoDB versioning fixture assigns dummy credentials directly to
os.environ, leaving them in the pytest worker after the mock ends.Use pytest's
monkeypatchfixture for all five AWS environment overrides so teardown restores the original credentials and region, including when a test fails. No tests are skipped and no runtime store behavior changes.Validation:
--noconftest.git diff --checkpass.Failing master run: https://github.com/feast-dev/feast/actions/runs/43198360331
The separate unit workflow failure is a macOS ARM runner-acquisition failure; the other five unit jobs pass. That job was retried separately.