Skip to content

fix: Wraps Trino queries in parens - #7018

Open
Marcus-Rosti wants to merge 4 commits into
feast-dev:masterfrom
Marcus-Rosti:mrosti/fix-trino-query-compute-engine
Open

fix: Wraps Trino queries in parens#7018
Marcus-Rosti wants to merge 4 commits into
feast-dev:masterfrom
Marcus-Rosti:mrosti/fix-trino-query-compute-engine

Conversation

@Marcus-Rosti

@Marcus-Rosti Marcus-Rosti commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Wraps offline store queries in ( )

Which issue(s) this PR fixes:

Fixes #7017

Checks

  • I've made sure the tests are passing.
  • My commits are signed off (git commit -s)
  • My PR title follows conventional commits format

Testing Strategy

  • Unit tests
  • Integration tests
  • Manual tests
  • Testing is not required for this change

Misc

@Marcus-Rosti
Marcus-Rosti requested a review from a team as a code owner October 14, 2026 23:39
@codecov-commenter

codecov-commenter commented Oct 14, 2026 •
edited
Loading

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.48%. Comparing base (cc17aad) to head (e13d0a3).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7018      +/-   ##
==========================================
+ Coverage   52.45%   52.48%   +0.03%     
==========================================
  Files         459      459              
  Lines       58172    58174       +2     
  Branches     8577     8578       +1     
==========================================
+ Hits        30515    30535      +20     
+ Misses      25573    25554      -19     
- Partials     2084     2085       +1
Flag Coverage Δ
go-feature-server 30.96% <ø> (ø)
python-unit 54.00% <100.00%> (+0.03%) ⬆️
Files with missing lines Coverage Δ
...stores/contrib/trino_offline_store/trino_source.py 75.49% <100.00%> (+18.49%) ⬆️

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc17aad...e13d0a3. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

haoxu0
haoxu0 approved these changes Oct 15, 2026
View reviewed changes

@haoxu0 haoxu0 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Marcus-Rosti Marcus-Rosti mentioned this pull request Oct 16, 2026
Open
@Marcus-Rosti

Marcus-Rosti commented Nov 9, 2026

Copy link
Copy Markdown
Contributor Author

@ntkathole Hey hoping to get this in before the next release!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haoxu0 haoxu0 haoxu0 approved these changes

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TrinoSource.get_table_query_string() omits parentheses around query, causing SQL syntax errors in Trino compute engine

3 participants

@Marcus-Rosti @codecov-commenter @haoxu0