Repository navigation
feat: Configure file paths for dbt imports - #7016
Open
luc-pimentel wants to merge 2 commits into
Open
luc-pimentel wants to merge 2 commits into
luc-pimentel wants to merge 2 commits into
Conversation
Author
|
Could someone please approve the pending workflows on this PR when you have a chance? Thanks! |
Signed-off-by: Lucas Pimentel <[email protected]>
Share path-template validation and expansion between direct imports and generated definitions, preserving the default path and Python literals. Signed-off-by: Lucas Pimentel <[email protected]>
Author
|
Rebased onto master to resolve the conflict with #7067 in |
luc-pimentel
force-pushed
the
fix/5874-dbt-file-path-template
branch
from
November 10, 2026 11:28
573a437 to
dd01419
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds optional
--file-path-templatesupport tofeast dbt import, using{model}for the dbt model name. Direct registry imports and generated Python definitions share the same path resolution. Omitting the option keeps/data/{model}.parquet.Invalid templates and use with non-file sources produce clear errors. Generated definitions preserve quotes, backslashes and other characters in paths. The Python APIs and documentation are updated too.
Which issue(s) this PR fixes:
Fixes #5874
Checks
git commit -s)Testing Strategy
All 117 scoped dbt tests pass. New cases cover real local Parquet retrieval through both CLI modes, relative paths, template validation, generated-string roundtrips and existing defaults. The before/after reproduction passes its controls. Scoped Ruff, formatting and mypy checks pass.
Misc
AI-assisted implementation and tests.