Skip to content

chore: Set upper bound for moto package - #3937

Merged
haoxu0 merged 1 commit into
feast-dev:masterfrom
sudohainguyen:moto
Feb 7, 2024
Merged

chore: Set upper bound for moto package#3937
haoxu0 merged 1 commit into
feast-dev:masterfrom
sudohainguyen:moto

Conversation

@sudohainguyen

@sudohainguyen sudohainguyen commented Feb 7, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it: moto package just recently released version 5.0.0 with some breaking changes, which potentially break our integration tests, so that the upper bound for the package is needed

Which issue(s) this PR fixes:

N/A

Note: no need to re-compile requirements files since moto is still <5

@sudohainguyen sudohainguyen changed the title chore: set upper bound for moto package chore: Set upper bound for moto package Feb 7, 2024
@sudohainguyen
sudohainguyen requested a review from haoxu0 February 7, 2024 02:33
@haoxu0

haoxu0 commented Feb 7, 2024

Copy link
Copy Markdown
Collaborator

Lint failed

@sudohainguyen

sudohainguyen commented Feb 7, 2024

Copy link
Copy Markdown
Collaborator Author

Lint failed

hmm I'm seeing all checks passed

@haoxu0

haoxu0 commented Feb 7, 2024

Copy link
Copy Markdown
Collaborator

Lint failed

hmm I'm seeing all checks passed

I'm seeing this one failed: https://github.com/feast-dev/feast/actions/runs/7809136271/job/21300448191#step:2:1,
Is it staled?

@sudohainguyen

sudohainguyen commented Feb 7, 2024

Copy link
Copy Markdown
Collaborator Author

Lint failed

hmm I'm seeing all checks passed

I'm seeing this one failed: https://github.com/feast-dev/feast/actions/runs/7809136271/job/21300448191#step:2:1, Is it staled?

yeah it is staled, already fixed 😄

haoxu0
haoxu0 approved these changes Feb 7, 2024
View reviewed changes

@haoxu0 haoxu0 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@haoxu0

haoxu0 commented Feb 7, 2024

Copy link
Copy Markdown
Collaborator

Lint failed

hmm I'm seeing all checks passed

I'm seeing this one failed: https://github.com/feast-dev/feast/actions/runs/7809136271/job/21300448191#step:2:1, Is it staled?

yeah it is staled, already fixed 😄

yeah staled on my phone lol

@haoxu0
haoxu0 merged commit b4aed65 into feast-dev:master Feb 7, 2024
zseta pushed a commit to zseta/feast that referenced this pull request Feb 7, 2024
@sudohainguyen @zseta
chore: Set upper bound for moto package (feast-dev#3937)
c646d03 
chore: set upper bound for moto package

Signed-off-by: Hai Nguyen <[email protected]>
Signed-off-by: Attila Toth <[email protected]>
@sudohainguyen
sudohainguyen deleted the moto branch February 8, 2024 03:48
tqtensor pushed a commit to tqtensor/feast that referenced this pull request Mar 11, 2024
@sudohainguyen @tqtensor
chore: Set upper bound for moto package (feast-dev#3937)
f50c5ed 
chore: set upper bound for moto package

Signed-off-by: Hai Nguyen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haoxu0 haoxu0 haoxu0 approved these changes

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sudohainguyen @haoxu0