Skip to content

chore: Extend pandas version support - #3664

Closed
sudohainguyen wants to merge 6 commits into
feast-dev:masterfrom
sudohainguyen:deps/pandas
Closed

sudohainguyen wants to merge 6 commits into
feast-dev:masterfrom
sudohainguyen:deps/pandas

Conversation

@sudohainguyen

@sudohainguyen sudohainguyen commented Jun 30, 2023 •

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #3709

@adchia adchia left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, sudohainguyen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sudohainguyen

Copy link
Copy Markdown
Collaborator Author

hi @adchia java integration test failed

@feast-ci-bot

Copy link
Copy Markdown
Collaborator

New changes are detected. LGTM label has been removed.

@feast-ci-bot feast-ci-bot removed the lgtm label Jul 11, 2023
@sudohainguyen

Copy link
Copy Markdown
Collaborator Author

just retriggered the pipelines, please approve again @adchia

@adchia

adchia commented Sep 7, 2023

Copy link
Copy Markdown
Collaborator

Turns out this was a legitimate error (the tests also showed an issue with the pyarrow version used in the java tests). Fixed it + updated teh requirements.txt files too

@adchia

adchia commented Sep 7, 2023

Copy link
Copy Markdown
Collaborator

Looks like there's some failing tests from the upgrade

@sudohainguyen
sudohainguyen marked this pull request as draft September 23, 2023 09:50
@sudohainguyen

sudohainguyen commented Sep 23, 2023 •

Copy link
Copy Markdown
Collaborator Author

https://stackoverflow.com/questions/76389694/transforming-pyspark-to-pandas-dataframe

looks like latest pyspark is not ready yet for pandas 2.0 (will be fixed in pyspark 4.0.0 apache/spark#42920)

we're encountering the same issue with datetime64 dtype

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pandas 2.0 support

3 participants