Skip to content

chore: Remove go server references - #3554

Merged
feast-ci-bot merged 3 commits into
feast-dev:masterfrom
achals:achal/more-go-deletion
Mar 24, 2023
Merged

feast-ci-bot merged 3 commits into
feast-dev:masterfrom
achals:achal/more-go-deletion

Conversation

@achals

@achals achals commented Mar 23, 2023

Copy link
Copy Markdown
Member

What this PR does / why we need it:

As title. This cleans up dead/unused code from Feast.

Which issue(s) this PR fixes:

Fixes #

Comment thread sdk/python/feast/feature_store.py Resolved
@feast-ci-bot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, kevjumba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kevjumba

Copy link
Copy Markdown
Collaborator

/lgtm

Signed-off-by: Achal Shah <[email protected]>
@feast-ci-bot feast-ci-bot removed the lgtm label Mar 23, 2023
@feast-ci-bot

Copy link
Copy Markdown
Collaborator

New changes are detected. LGTM label has been removed.

@kevjumba

Copy link
Copy Markdown
Collaborator

/lgtm

@feast-ci-bot
feast-ci-bot merged commit 5e62844 into feast-dev:master Mar 24, 2023
@judahrand

Copy link
Copy Markdown
Member

Any reason to not also remove the embedded_go module?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants