Skip to content

ci: Fix release process to find breaking changes - #3021

Merged
feast-ci-bot merged 2 commits into
feast-dev:masterfrom
felixwang9817:fix_release_process
Aug 5, 2022
Merged

feast-ci-bot merged 2 commits into
feast-dev:masterfrom
felixwang9817:fix_release_process

Conversation

@felixwang9817

Copy link
Copy Markdown
Collaborator

Signed-off-by: Felix Wang [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Signed-off-by: Felix Wang <[email protected]>

@achals achals left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [achals,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter

codecov-commenter commented Aug 5, 2022 •

Copy link
Copy Markdown

Codecov Report

Merging #3021 (9e071e8) into master (c02120d) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3021      +/-   ##
==========================================
- Coverage   77.59%   77.58%   -0.02%     
==========================================
  Files         194      194              
  Lines       16267    16267              
==========================================
- Hits        12622    12620       -2     
- Misses       3645     3647       +2     
Flag Coverage Δ
integrationtests 67.23% <ø> (-0.15%) ⬇️
unittests 59.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/infra/online_stores/datastore.py 87.96% <0.00%> (-1.39%) ⬇️
...east/infra/materialization/lambda/lambda_engine.py 93.75% <0.00%> (+1.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@feast-ci-bot
feast-ci-bot merged commit 826da67 into feast-dev:master Aug 5, 2022
adchia pushed a commit that referenced this pull request Aug 5, 2022
* Fix release process to find breaking changes

Signed-off-by: Felix Wang <[email protected]>

* Add comments

Signed-off-by: Felix Wang <[email protected]>
adchia pushed a commit that referenced this pull request Aug 10, 2022
* Fix release process to find breaking changes

Signed-off-by: Felix Wang <[email protected]>

* Add comments

Signed-off-by: Felix Wang <[email protected]>
adchia pushed a commit that referenced this pull request Aug 10, 2022
* Fix release process to find breaking changes

Signed-off-by: Felix Wang <[email protected]>

* Add comments

Signed-off-by: Felix Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants