Skip to content

Tutorial on validation of historical features - #2277

Merged
feast-ci-bot merged 4 commits into
feast-dev:masterfrom
pyalex:docs/dqm-tutorial
Feb 3, 2022
Merged

Tutorial on validation of historical features#2277
feast-ci-bot merged 4 commits into
feast-dev:masterfrom
pyalex:docs/dqm-tutorial

Conversation

@pyalex

@pyalex pyalex commented Feb 3, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

pyalex added 2 commits February 3, 2022 16:57
@pyalex
dqm tutorial in docs
3abb5a4 
Signed-off-by: pyalex <[email protected]>
@pyalex
gh link
98f0cbf 
Signed-off-by: pyalex <[email protected]>
@pyalex
pyalex requested a review from a team as a code owner February 3, 2022 08:59
@pyalex
pyalex requested review from woop and removed request for a team February 3, 2022 09:00
@pyalex pyalex added kind/feature New feature or request and removed size/XXL labels Feb 3, 2022
@pyalex
cleanup
122302a 
Signed-off-by: pyalex <[email protected]>
@pyalex
typo
9eaa5f5 
Signed-off-by: pyalex <[email protected]>
@pyalex
pyalex force-pushed the docs/dqm-tutorial branch from 9a192dc to 9eaa5f5 Compare February 3, 2022 09:33
@codecov-commenter

codecov-commenter commented Feb 3, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2277 (9a192dc) into master (bb676f2) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head 9a192dc differs from pull request most recent head 9eaa5f5. Consider uploading reports for the commit 9eaa5f5 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2277      +/-   ##
==========================================
- Coverage   58.60%   58.59%   -0.01%     
==========================================
  Files         116      116              
  Lines        9810     9811       +1     
==========================================
  Hits         5749     5749              
- Misses       4061     4062       +1
Flag Coverage Δ
unittests 58.59% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../integration/online_store/test_universal_online.py 14.93% <0.00%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb676f2...9eaa5f5. Read the comment docs.

adchia
adchia approved these changes Feb 3, 2022
View reviewed changes

@adchia adchia left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot

feast-ci-bot commented Feb 3, 2022

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, pyalex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot
feast-ci-bot merged commit fb995a2 into feast-dev:master Feb 3, 2022
@adchia adchia linked an issue Apr 21, 2022 that may be closed by this pull request
Data quality monitoring #2596
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adchia adchia adchia approved these changes
@woop woop Awaiting requested review from woop woop was automatically assigned from feast-dev/maintainers

Assignees

@adchia adchia

@woop woop

Labels

approved area/documentation kind/feature New feature or request lgtm release-note-none size/XL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Data quality monitoring

5 participants

@pyalex @codecov-commenter @feast-ci-bot @adchia @woop